Support PHP-PM by resetting state

Question

Support PHP-PM by resetting state

Sander-Toonen opened this issue 6 years ago · comments

When using this bundle with php-pm the breadcrumbs show alls paths that all previous users have visited. E.g:

Home > Register > Home > Profile > Change Password > Home > Contact > Home > Contact, ... etc

This happens because WhiteOctober\BreadcrumbsBundle\Model\Breadcrumbs is a service that keeps state. Symfony 3.3 added a dependency injection tag that allows Symfony to call a reset()-method on the service after a request has been processed. This way, services can clean up any state so that a next request can be processed.

Symfony itself is already resetting certain services: symfony/symfony#23984

Since the Breadcrumbs class already has a clear() method that does exactly what is needed, adding the DI-tag should be all that is needed. I'll add a PR soon.

Chris Stenke · Answer 1 · Sat Apr 28 2018 17:38:45 GMT+0800 (China Standard Time)

Would like to see this merged :)

Sam Partington · Answer 2 · Tue May 01 2018 17:58:48 GMT+0800 (China Standard Time)

Thanks all for your patience & contributions. This is now in release https://github.com/whiteoctober/BreadcrumbsBundle/releases/tag/1.4.2.