Display request

Question

Display request

crazyanageek opened this issue 7 years ago · comments

Hello !

First I would like to thank you for this amazing module ! We use it every day with my wife and it is super handy.

I would like to know if it would be possible to display the address set for the current day. To be clearer, I have set a different address for each day of the week and I would like it to appear under "Home to work".

Is it possible/easy to do that ?

Cheers !

saml-dev · Answer 1 · Mon Mar 19 2018 21:56:09 GMT+0800 (China Standard Time)

Glad you like the module! This shouldn't be too hard to implement, I'll try to take a look at it this week. Thanks for the idea!

crazyanageek · Answer 2 · Mon Mar 19 2018 22:17:09 GMT+0800 (China Standard Time)

That would be amazing ! Thank you so much !

saml-dev · Answer 3 · Fri Mar 23 2018 10:42:57 GMT+0800 (China Standard Time)

I just committed a new version with two new options: showAddress and showAddressText which will let you customize the way the address is displayed. It will be displayed underneath the route name as you requested. Give it a try and let me know what you think!

crazyanageek · Answer 4 · Fri Mar 23 2018 14:22:49 GMT+0800 (China Standard Time)

This is amazing Sam !! Thank you so much! I will try as soon as I come back from work. Cheers !

…

On Fri, Mar 23, 2018, 03:43 Sam Lewis ***@***.***> wrote: I just committed a new version with two new options: showAddress and showAddress which will let you customize the way the address is displayed. It will be displayed underneath the route name as you requested. Give it a try and let me know what you think! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjSq51HOWq1Qr7CsFSvGni95HmPuHwczks5thGE0gaJpZM4SuvX6> .

crazyanageek · Answer 5 · Fri Mar 23 2018 22:37:23 GMT+0800 (China Standard Time)

Works like a charm ! Really perfect !! Thank you, thank you, thank you !! Cheers Jonathan

…

On Fri, Mar 23, 2018, 03:43 Sam Lewis ***@***.***> wrote: I just committed a new version with two new options: showAddress and showAddress which will let you customize the way the address is displayed. It will be displayed underneath the route name as you requested. Give it a try and let me know what you think! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjSq51HOWq1Qr7CsFSvGni95HmPuHwczks5thGE0gaJpZM4SuvX6> .

crazyanageek · Answer 6 · Sat Mar 24 2018 14:53:41 GMT+0800 (China Standard Time)

Hello Sam, Last question, I have setup a destination for Saturday and Sunday in your module (because I have to work on weekends unfortunately) and it's not displaying them (I wrote : sat_destination and sun_destination). Do you know why ? Cheers ! Jonathan

…

On Fri, Mar 23, 2018, 03:43 Sam Lewis ***@***.***> wrote: I just committed a new version with two new options: showAddress and showAddress which will let you customize the way the address is displayed. It will be displayed underneath the route name as you requested. Give it a try and let me know what you think! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjSq51HOWq1Qr7CsFSvGni95HmPuHwczks5thGE0gaJpZM4SuvX6> .

saml-dev · Answer 7 · Sun Mar 25 2018 09:35:00 GMT+0800 (China Standard Time)

The code for specific destinations on specific days was contributed by another user and they didn't support saturdays and sundays. I just pushed another update that adds support for those days. Enjoy! 😃

crazyanageek · Answer 8 · Sun Mar 25 2018 15:31:53 GMT+0800 (China Standard Time)

Hello Sam, You are a true master !! Thank you so much. Buy any chance do you have a tipeee account or any account somewhere I could tip you to truly thank you? Cheers. Jonathan

…

On Sun, Mar 25, 2018, 03:35 Sam Lewis ***@***.***> wrote: The code for specific destinations on specific days was contributed by another user and they didn't support saturdays and sundays. I just pushed another update that adds support for those days. Enjoy! 😃 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjSq569bXuHSrKkheJpzuXZRQSILymX-ks5thvREgaJpZM4SuvX6> .

saml-dev · Answer 9 · Sun Mar 25 2018 23:18:07 GMT+0800 (China Standard Time)

Of course not! This was a fun project for me just before I finished my undergraduate degree and I'm happy to support it moving forward. Now that I work full time I don't have as much time to contribute but the changes you requested weren't too complex to implement. As long as you enjoy the module that's all the thanks I need! 😁

crazyanageek · Answer 10 · Sun Mar 25 2018 23:33:13 GMT+0800 (China Standard Time)

Your very kind ! If one day you travel to Switzerland, let me know and I will give you a tour ! Cheers. Jonathan

…

On Sun, Mar 25, 2018, 17:18 Sam Lewis ***@***.***> wrote: Of course not! This was a fun project for me just before I finished my undergraduate degree and I'm happy to support it moving forward. Now that I work full time I don't have as much time to contribute but the changes you requested weren't too complex to implement. As long as you enjoy the module that's all the thanks I need! 😁 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjSq5xOIWPg1CLOjUS1W1LtKPW7zbIM5ks5th7UvgaJpZM4SuvX6> .

saml-dev · Answer 11 · Sun Mar 25 2018 23:48:37 GMT+0800 (China Standard Time)

Sounds great to me!

saml-dev · Answer 12 · Mon Mar 26 2018 01:26:05 GMT+0800 (China Standard Time)

Hey Jonathan, I just fixed a bug with sun_destination so you'll want to update to make sure it works correctly. I also added in day-specific route names, in case you'd rather use that instead of the address to show which route you're seeing.

crazyanageek · Answer 13 · Mon Mar 26 2018 18:32:54 GMT+0800 (China Standard Time)

Hi Sam, perfect ! I will try the patch when I get back home ! Cheers! Jonathan

…

On Sun, Mar 25, 2018, 19:26 Sam Lewis ***@***.***> wrote: Hey Jonathan, I just fixed a bug with sun_destination so you'll want to update to make sure it works correctly. I also added in day-specific route names, in case you'd rather use that instead of the address to show which route you're seeing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjSq59ysLwpcgFQdpWI1Jq85WduDSMgzks5th9MtgaJpZM4SuvX6> .

crazyanageek · Answer 14 · Wed Mar 28 2018 03:09:15 GMT+0800 (China Standard Time)

Everything works really well now !! It's really good to be able to give a "route name". Cheers !! Jonathan 2018-03-26 12:32 GMT+02:00 This is AO <kiwikiblue@gmail.com>:

…

Hi Sam, perfect ! I will try the patch when I get back home ! Cheers! Jonathan On Sun, Mar 25, 2018, 19:26 Sam Lewis ***@***.***> wrote: > Hey Jonathan, I just fixed a bug with sun_destination so you'll want to > update to make sure it works correctly. I also added in day-specific route > names, in case you'd rather use that instead of the address to show which > route you're seeing. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#60 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AjSq59ysLwpcgFQdpWI1Jq85WduDSMgzks5th9MtgaJpZM4SuvX6> > . >