Giters

samhocevar / lolremez

📈 Polynomial Approximations using the Remez Algorithm

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SLN File no longer compiles

freeone3000 opened this issue · comments

commented

The SLN file appears to be missing a reference to the lol/ directory as an include directory. In addition, the Win8.1 SDK (in contrast with the Win10 SDK) does not include float.h. As such, the project does not compile. I've attempted to retarget against Win10 SDK with build tools 137, but this did not solve the issue.

commented

Thanks for reporting this. Unfortunately Visual Studio is not very smart and doesn’t understand that retargeting the project requires modifying Directory.Build.props rather than lolremez.vcxproj. I’ve fixed the issue in d0e62f8.

commented

Thanks for the fix. The reference to build tools v143 in lolremez.vcxproj versus v142 in Directory.Build.props made the project not compile on my machine (windows). Referring to v142 everywhere fixed it.