s/SSL/TLS/

Question

s/SSL/TLS/

dbrgn opened this issue 7 years ago · comments

We should rename the --sslcert and --sslkey options to --tlscert and --tlskey. Similarly, the -sk and -tk options could be renamed too. SSL is dead :)

To provide backwards compatibility the options could still be supported, but not documented in the --help output.

Lenny · Answer 1 · Thu Sep 21 2017 18:50:47 GMT+0800 (China Standard Time)

This is fine by me although my personal opinion is that SSL is synonymous to TLS today and I don't believe it will ever change, see for example: https://docs.python.org/3/library/ssl.html

I'm pretty sure we can add an alias option in click but I don't think there's a way to hide a specific one. I'd be fine with just an alias.

Danilo Bargen · Answer 2 · Fri Sep 22 2017 02:02:53 GMT+0800 (China Standard Time)

Python has reverse compatibility issues. We don't.

We can document the SSL versions as a deprecated alias of the TLS versions and remove them after a few releases.

Lenny · Answer 3 · Fri Sep 22 2017 04:22:34 GMT+0800 (China Standard Time)

Again, I'm fine if we change it but I personally don't really care. 😅

Danilo Bargen · Answer 4 · Fri Sep 22 2017 04:37:42 GMT+0800 (China Standard Time)

Ok, I'll provide a PR sometime :)

Lenny · Answer 5 · Thu Aug 30 2018 23:29:49 GMT+0800 (China Standard Time)

Closed due to inactivity.

rugk · Answer 6 · Thu Aug 30 2018 23:35:45 GMT+0800 (China Standard Time)

But, but, but… it's not "fixed". 😑

Lenny · Answer 7 · Thu Aug 30 2018 23:48:33 GMT+0800 (China Standard Time)

The wontfix label should indicate that I'll accept PRs for this. It's just not going to be me who will create that PR.

Danilo Bargen · Answer 8 · Thu Aug 30 2018 23:55:27 GMT+0800 (China Standard Time)

I'll provide a PR.