Better logging of unsupported subprotocol
dbrgn opened this issue · comments
When specifying an unsupported subprotocol, the error msg is as follows:
[2017-02-07 08:06:45.943390] NOTICE: saltyrtc.server: Unsupported sub-protocol 'None', dropping client
Would it be possible to actually print the string specified by the client? Or is that functionality hidden in the websockets implementation? (I tried to fix it for 10 minutes, but didn't find the correct place where the subprotocol string is parsed...)
AFAIK None stands for no sub-protocol provided. It should log the supplied sub-protocols. If it doesn't, that might be a bug.
Are you sure that you've provided a sub-protocol?
Yes, I'm sure. If I remember correctly the client used v1.saltyrtc.org while the server used v0.saltyrtc.org.
Might be a limitation of the WebSocket implementation the server uses. Let me check that.
Yes, it's a limitation of the websockets implementation. I have changed the log output to be less confusing.