ccleaner.sls breaks winrepo.genrepo

Question

ccleaner.sls breaks winrepo.genrepo

TheBigBear opened this issue 9 years ago · comments

TheBigBear commented 9 years ago

when running winrepo.genrepo it complains about blocks in ccleaner.sls

David Boucha · Answer 1 · Fri Feb 13 2015 05:06:50 GMT+0800 (China Standard Time)

can you provide cli output on that?

TheBigBear · Answer 2 · Fri Feb 13 2015 05:11:36 GMT+0800 (China Standard Time)

Hi,

Sorry I over-reacted. I had missed a missing “:”. Have fixed it and submitted PR.

Also found similar but milder winrepo.genrepo syntax issues of misaligned blocks in other files. have created PRs for them. All should be well.

On 12 Feb 2015, at 21:06, David Boucha notifications@github.com wrote:

can you provide cli output on that?

—
Reply to this email directly or view it on GitHub #155 (comment).

TheBigBear · Answer 3 · Sat Feb 14 2015 01:31:10 GMT+0800 (China Standard Time)

Ok, sure, sorry I didn;'t include it. It seemed obvious to e that it was my inexperience with python and keeping things nealty lined up in blocks.

salt-run winrepo.genrepo
Failed to compile /srv/salt/win/repo/salt-winrepo.git/ccleaner.sls: while parsing a block mapping
  in "<string>", line 3, column 5:
        installer: 'http://download.piri ... 
        ^
expected <block end>, but found '<block mapping start>'
  in "<string>", line 4, column 6:
         full_name: 'CCleaner 5.02'
         ^

My PR above fixes this and the winrepo.genrepo complaints go away so I think it fixes #156