On standard.tmpl Customlog and Logformat directive leads to an error

Question

On standard.tmpl Customlog and Logformat directive leads to an error

tsenay opened this issue 7 years ago · comments

On my RHEL 7.4 with httpd 2.4.6, the Logformat and Customlog merged directive does not work

 {% if site.get('CustomLog') != False -%}CustomLog {{ vals.CustomLog }} {{ vals.LogFormat }}{% endif %}

This version works better

    {% if site.get('LogFormat') != False -%}LogFormat {{ vals.LogFormat }}{% endif %}
    {% if site.get('CustomLog') != False -%}CustomLog {{ vals.CustomLog }} {% endif %}

can you consider update it ?

Javier Bértoli · Answer 1 · Sat Nov 11 2017 03:54:27 GMT+0800 (China Standard Time)

Hi @tsenay, mind you submit a PR with the changes you're proposing?

Thomas Senay · Answer 2 · Wed Nov 15 2017 04:56:16 GMT+0800 (China Standard Time)

PR Merged into master

Matt M. · Answer 3 · Sat Nov 25 2017 00:37:48 GMT+0800 (China Standard Time)

Apologies for the issue necromancy, but I believe this change probably breaks things. On Apache 2.4.x (and probably earlier too) the CustomLog directive takes at least two arguments; with this change, it will now only have one argument.

Tested on CentOS 7.4 using Apache 2.4.6.

Thomas Senay · Answer 4 · Sat Nov 25 2017 01:10:47 GMT+0800 (China Standard Time)

Use a string to set up value
CustomLog: ‘pattern name’

Matt M. · Answer 5 · Sat Nov 25 2017 01:43:16 GMT+0800 (China Standard Time)

@tsenay I'm not specifying any CustomLog directive in my pillar data, so I'm using only the defaults provided by the formula; the defaults are now broken as a result of this change.