salomvary / soundcleod

SoundCloud for macOS and Windows

Home Page:https://soundcleod.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Security: disable "remote" module

salomvary opened this issue · comments

https://electronjs.org/docs/tutorial/security#15-disable-the-remote-module

Electron Security Warning (enableRemoteModule) This renderer process has "enableRemoteModule" enabled
    and attempted to load remote content from 'https://soundcloud.com/'. This
    exposes users of this app to unnecessary security risks.

For more information and help, consult
https://electronjs.org/docs/tutorial/security.
This warning will not show up
once the app is packaged.

The solution should be something like this:

https://github.com/brave/browser-laptop/blob/5e11e36828eae0e434b87245a7b1abe927b21226/app/browser/windows.js#L313-L324

https://github.com/brave/browser-laptop/blob/5e11e36828eae0e434b87245a7b1abe927b21226/app/renderer/components/main/main.js#L222