When closing app on Mojave getting error message

Question

When closing app on Mojave getting error message

emadg opened this issue 6 years ago · comments

Emad Gohari commented 6 years ago

Whenever closing the app on macOS Mojave, an error message is shown that "SoundCleod stopped working unexpectedly".

Johan Bergström · Answer 1 · Tue Oct 09 2018 21:45:13 GMT+0800 (China Standard Time)

Looks like this: electron/electron#8459

I ran into this while looking at updating to electron 3 (cpu usage way down!).

Márton Salomváry · Answer 2 · Wed Oct 10 2018 17:11:12 GMT+0800 (China Standard Time)

I’m on my way back from holidays, will hopefully be able to address Mojave bugs in a couple of days. #solomaintainer

…

On 1. Oct 2018, at 01:38, emadg ***@***.***> wrote: Whenever closing the app on macOS Mojave, an error message is shown that "SoundCleod stopped working unexpectedly". — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Johan Bergström · Answer 3 · Wed Oct 10 2018 20:24:14 GMT+0800 (China Standard Time)

I can confirm that removing the global shortcuts (which at least in electron 3 doesn't seem to work anyway) fixes the issue. De-registering them through the quit event seems to do nothing unfortunately.

Johan Bergström · Answer 4 · Thu Oct 11 2018 01:13:03 GMT+0800 (China Standard Time)

A more recent upstream issue: electron/electron#14837

Márton Salomváry · Answer 5 · Fri Oct 12 2018 19:34:42 GMT+0800 (China Standard Time)

Created a pre-release with latest Electron here: https://github.com/salomvary/soundcleod/releases/tag/v1.4.1-pre.0

As I have not upgraded to Mojave yet, please test and send feedback whether this version fixes the problem.

Johan Bergström · Answer 6 · Fri Oct 12 2018 21:17:50 GMT+0800 (China Standard Time)

Created a pre-release with latest Electron here: https://github.com/salomvary/soundcleod/releases/tag/v1.4.1-pre.0

Nope, still broken.

Johan Bergström · Answer 7 · Fri Oct 12 2018 21:30:14 GMT+0800 (China Standard Time)

Also, worth pointing out:

#solomaintainer

I think you're doing an excellent job.

Márton Salomváry · Answer 8 · Sat Oct 13 2018 01:15:43 GMT+0800 (China Standard Time)

Also, worth pointing out:

#solomaintainer

I think you're doing an excellent job.

Thanks, trying to do my best:)

Thanks for trying, will wait for an Electron update then...

Johan Bergström · Answer 9 · Wed Oct 24 2018 08:32:03 GMT+0800 (China Standard Time)

FWIW, I've tested electron 4 and ran into the same issue. This actually made me revert back to the webview branch. Looks like cpu usage (at least on macos) is equal to electron.

Márton Salomváry · Answer 10 · Mon Oct 29 2018 01:47:51 GMT+0800 (China Standard Time)

See #174 for workaround.

Márton Salomváry · Answer 11 · Tue May 19 2020 21:44:50 GMT+0800 (China Standard Time)

Should be fixed in 2.0.0.