saket / press

Cross-platform markdown editor written in Kotlin Multiplatform (work in progress)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ordered lists doesn't auto complete

ChanSek opened this issue · comments

If I am at an item of an ordered list, then pressing enter should show the next number of the list by default. But this happens only if your previous item ends wjth a period (.) symbol.

You can reproduce it by doing two below tests.

  1. Type something

vs

  1. Type something.

Interesting. It works fine for me on a Pixel 3 and a Galaxy Fold 2:

VN20210119_125453_2.mp4

The tests for the text formatter (AutoFormatOnEnterPressTest) are passing just fine, so I suspect there's something weird happening with the way Press detects enter key presses on your phone/keyboard.

Can you help me debug this by placing a breakpoint here?

val enterPressed = source == "\n" && end - start == 1

Looks like, there is some corner case which I am not able to find it right now. Will update if I am able to reproduce it.

For now, you can close the issue.

Looks like, there is some corner case which I am not able to find it right now. Will update if I am able to reproduce it.

For now, you can close the issue.

If you add a blank space before pressing enter it should works. I think it's related to the keyboard you used. I get this weird behavior while using the beta version of Gboard, the autocompletition works as expected with swiftkey and stable Gboard

That is very useful information, thank you! I was able to reproduce this with gboard beta. Gotta rethink how Press detects enter key presses.

Fixed by 6808501. Will release this as part of v1.8. Thanks @manueldidonna and @ChanSek!