saket / press

The handles that appear when selecting text to allow for more precision, are enormous.

Can you post your device and OS details?

Is this the first time you encounter this bug?

Yep. Chinese OEMs are notoriously bad at messing up with system stuff 🤦‍♂. All I'm doing is applying a ColorFilter on the selection handle drawables. Not sure what's the issue here. I don't have a Redmi so it's going to be difficult for me to debug this. Wanna help me out?

How could I do that? I'm not quite sure.
It also seemed weird to me because most apps have the android default handles, despite them being a bit off to their theme and overall color scheme.

It also seemed weird to me because most apps have the android default handles, despite them being a bit off to their theme and overall color scheme.

Because other apps don't change them at runtime. I want Press to have dynamic themes that can be changed without restarting the app.

How could I do that? I'm not quite sure.

I'd start by changing the PorterDuff.Mode value passed to setColorFilter here to make sure that's not the cause:

press/androidApp/src/main/java/press/theme/ThemedWidgets.kt

Line 61 in f46e6c9

    
           selectionHandleDrawables.forEach { it.setColorFilter(palette.accentColor, SRC_IN) }

Oh man I know 0 Kotlin. I'm so sorry.
I'm glad I found the bug and that you seem to have a method in mind to attack this.

I have a test device with MiUI. I can try reproducing the issue and changing the PorterDuff.Mode when I am back at work

@SubhrajyotiSen that would be dope. Thank you!

So someone took the device home and is now on vacation. So it might be a few days before I can help with this

sads.gif

I'll also try finding someone with a Xiaomi device when I'm visiting India next month.

Hi, is the issue resolved yet? If not I can test it on a Redmi device today and play with PorterDuff.Mode to see if it's the culprit

Please go ahead! I wasn't able to find enough time for this.

@boyangwang was wondering if were able to find anything?

MIUI modified the native cursor-related API, so it doesn't support to modify the cursor or selection handles. It is currently recommended to skip MIUI for your theme logic. I have helped to report this problem to the MIUI team, and it should be fixed in the future.

@ChristosBouronikos can you check if the latest release change anything for you?

@saket I'm on a new OnePlus phone, so I had to find time to dig into my old Xiaomi phone.

Got the latest build.

Handles seem to be fine now. Just as I would expect.

Thanks for the good work!

Awesome, thanks for checking!

Text selection handles are broken.