sahana / eden

Sahana Eden is an Open Source Humanitarian Platform which can be used to provide solutions for Disaster Management, Development, and Environmental Management sectors.. Please sign CLA when submitting pull requests: http://bit.ly/SSF-eCLA

Home Page:http://eden.sahanafoundation.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Countries replaced during Warehouse import

trendspotter opened this issue · comments

Steps to reproduce:

  1. Go to Warehouses -> Warehouses -> Import
  2. Import a simple CSV file containing name and country - warehouses.txt (renamed to .txt because GitHub doesn't allow .csv attachments)
  3. Observe that the import job details don't display the country.
  4. Click on Import
  5. Navigate back to Warehouses -> Warehouses
  6. Observe that the countries differ from the import data (they are populated from a list of all countries in alphabetical order instead)

This happens also in different modules, e.g. Schools (edu), however doesn't happen in Organizations.

I think this is going to occur fairly widely.
It seems that whilst TUIDs only needed to be unique within a resource before, they are no longer, so resource prefixes are now critical, whereas before they were optional.
(I'm not sure what exactly caused this change)

I fixed the 2 you mention, if you find more then you should be able to easily fix using the same pattern :)

I really believe it didn't have to be....these import files used to work fine.
The other change is that records are now always imported in order, whereas before they were randomised.