Convert Type Annotations to Py3 syntax

Question

Convert Type Annotations to Py3 syntax

cooperlees opened this issue 5 years ago · comments

Since this project is now >= Python 3.5 we can move all type annotations to Python 3 syntax except variable annotations (they will need to stay as comments until the project is >= 3.6).

Happy to do the PR one day and also happy if someone else beats me. I did PR #75 to add CI type checking, ensuring master is passing before we convert.

Not sure if there are tools to do this for us, but manual wouldn’t take to long.

Michel Le Bihan · Answer 1 · Fri Dec 13 2019 03:37:23 GMT+0800 (China Standard Time)

I guess that it would also be good to annotate pycares.

Cooper Lees · Answer 2 · Fri Dec 13 2019 03:59:41 GMT+0800 (China Standard Time)

I guess that it would also be good to annotate pycares.

For sure. But I feel that should be an issue over at https://github.com/saghul/pycares :)

Cooper Lees · Answer 3 · Fri Dec 13 2019 04:04:07 GMT+0800 (China Standard Time)

Did it: saghul/pycares#112

Michel Le Bihan · Answer 4 · Fri Dec 13 2019 04:26:25 GMT+0800 (China Standard Time)

I opened a PR 😉