`install_requires` collides with `typing` for the standard library

Question

`install_requires` collides with `typing` for the standard library

eigenein opened this issue 5 years ago · comments

Pavel Perestoronin commented 5 years ago

Hi,

The install_requires section in setup.py contains typing dependency, which at least on my Python 3.7 collides with the standard typing and produces false-positive warnings in IDE.

Should it perhaps use environment markers to avoid installing the 3rd-party typing on the latest Python?

Regards,
Pavel

Saúl Ibarra Corretgé · Answer 1 · Mon Jan 28 2019 16:44:06 GMT+0800 (China Standard Time)

Hi @eigenein yes, this makes sense. Are you up for writing a PR?

Pavel Perestoronin · Answer 2 · Tue Jan 29 2019 03:00:34 GMT+0800 (China Standard Time)

Arthur was way faster 👍

Samuel Colvin · Answer 3 · Sat Feb 02 2019 00:59:27 GMT+0800 (China Standard Time)

Great thanks.

Would be good if we could get a release including this. Unfortunately, it upsets pycharm a lot.

Saúl Ibarra Corretgé · Answer 4 · Sat Feb 02 2019 20:08:01 GMT+0800 (China Standard Time)

@samuelcolvin 2.0.0b1 was released with this included.