saghul / aiodns

Simple DNS resolver for asyncio

Home Page:https://pypi.python.org/pypi/aiodns

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

DNSError inheritance

nibrag opened this issue · comments

loop.getaddrinfo (asyncio) raises socket.gaierror (inherited from OSError) when it fail.
It might be worth to aiodns.DNSError was also inherited from OSError?

class DNSError(OSError):
     pass

I don't think so. This is how Python describes such exception: https://docs.python.org/2/library/exceptions.html#exceptions.OSError

This is not a system error, but a DNS related one.