Due to the new release of pycares 1.0, the interface changed

Question

Due to the new release of pycares 1.0, the interface changed

mathieui opened this issue 9 years ago · comments

Because the API of pycares changed, the query function now returns a ares_query_simple_result where previously only a string was expected.

I don't know if that was intentional or not, but I consider it a bug for now.

Saúl Ibarra Corretgé · Answer 1 · Fri Sep 04 2015 15:11:16 GMT+0800 (China Standard Time)

@mathieui hi there! Big fan of poezio :-)

The change was intentional, so I'll bump the dependency in aiodns and call it an API change. With the new return type you can access the resolved name as well as the TTL.

Saúl Ibarra Corretgé · Answer 2 · Sat Sep 12 2015 18:03:20 GMT+0800 (China Standard Time)

@mathieui I just released aiodns 1.0.0, which uses pycares 1.0.0: https://github.com/saghul/aiodns/releases/tag/aiodns-1.0.0

I added some clarification to the README. You can now rely on the result objects to be consistent for the future. 👍

mathieui · Answer 3 · Sat Sep 12 2015 18:29:00 GMT+0800 (China Standard Time)

Thanks a lot, I’ll update poezio to use it