sachinchoolur / lightGallery

A customizable, modular, responsive, lightbox gallery plugin.

Home Page:https://www.lightgalleryjs.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Captions don't escape quotes

davlasq opened this issue · comments

Captions generated from alt attributes don't escape quotes even if they're already escaped in html, for example &quote; is changed to " what brokes DOM tree and image is not loading.

Hey @davlasq,

Could you please share the sample HTML? I'll take a look and get back to you

It looks like problem appears only when alt attribute contains html tag, for example
<a href="img.jpg"><img src="img.jpg" alt="lorem &quot;ipsum&quot;<br>lorem"></a>
In that case caption should be in data-sub-html attribute and it solves the problem so it's not that bad

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.