sachaos / viddy

👀 A modern watch command. Time machine and pager etc.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

How to prevent Memory Percentage increase over time?

gotbletu opened this issue · comments

hey i notice that if i leave viddy running for a few hours, the memory % would increase. Is there a way to prevent this?
viddy starts out at 0.1% after a few hours it would be over 4.0%.
the watch command is always at 0.0% even after a few hours.

Not sure if is due to the viddy time machine feature that records all the changes but if so, maybe add an option to disable it to prevent memory % increase.

# example
viddy -t man ffmpeg
viddy -t "ps -o pid,user,%mem,command ax | sort -b -k3 -r | grep -i viddy"

viddy 0.3.4-1
System: Host: arcolinux Kernel: 5.10.83-1-lts x86_64 bits: 64 Desktop: Xfce 4.16.0 Distro: ArcoLinux

commented

Same problem here, great application, but the memory usage slowly keeps going up until the system runs out of RAM.

It's probably worth setting like a 100 history limit by default but maybe make it configurable @sachaos ?

I'll try to solve this issue in this weekend.

I could not try. I'll do this in this week.

commented

I see that this feature branch was never merged into master. I would respectfully suggest that you do so, and cut a release. A lot of people use watch/viddy for long-running monitoring. The time machine functionality is neat, but not at the expense of unbounded memory consumption.

I see that this feature branch was never merged into master. I would respectfully suggest that you do so, and cut a release. A lot of people use watch/viddy for long-running monitoring. The time machine functionality is neat, but not at the expense of unbounded memory consumption.

Just had a box get into a state that required a total restart because of this.

Any update @sachaos ?

@onedr0p Hi thank you for ping.

I think there are many solutions.

  1. limit snapshot count.
  2. store history in file.
  3. Remove 0 diff snapshot.
    • I've merged #99