Giters

sacOO7 / SocketclusterClientDotNet

C# client for socketcluster framework in node.js

Home Page:http://socketcluster.io/#!/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Exceptions not handled during reconnect and setting Reconnect strategy equal to null causes null reference exception

ddslawson opened this issue · comments

commented

SocketclusterClientDotNet/ScClient/Socket.cs

Line 225 in 95332be

Connect();

I experienced an exception being thrown during the reconnect procedure. Specifically the exception said an attempt to connect was refused because an attempt to connect was already in progress. I believe some exception handling is needed on line 225 referenced above.

SocketclusterClientDotNet/ScClient/Socket.cs

Line 120 in 95332be

if (!_strategy.AreAttemptsComplete())

To work around this I tried to disable to the reconnect strategy so I could write my own. This caused a null reference exception to be thrown after OnDisconnect on my own IBasicListener implementation was called. I believe I have identified the problem on line 120 referenced above. It seems after calling OnDisconnect it calls _strategy.AreAttemptsComplete() without first checking is _strategy is not null.

I have found a workaround for the latter problem, which is to set the max attempts of the reconnect strategy to 0.