Build failure because of missing appstream
francoism90 opened this issue · comments
SABnzbd version
4.2.3
Operating system
Linux
Using Docker image
None
Description
See:
Unfortunately this would require a new version bump. Is this possible?
Thanks!
I don't get it? The 4.2.3 version is there?
@Safihre This file needs to be fixed according to the linter: https://github.com/sabnzbd/sabnzbd/blob/develop/linux/org.sabnzbd.sabnzbd.appdata.xml#L54
But you need to generate a new build.
Apparently the appstream spec changed:
asv-relation-display-length-value-invalid
org.sabnzbd.sabnzbd.appdata.xml:54 - small
This `display_length` item contains an invalid display length. Its value must be a positive integer value denoting logical pixels. Please refer to the AppStream specification for more information on this tag.
There's also this deprecation warning:
asv-developer-name-tag-deprecated
org.sabnzbd.sabnzbd.appdata.xml:58 -
The toplevel `developer_name` element is deprecated. Please use the `name` element in a `developer` block instead.
asv-developer-info-missing
org.sabnzbd.sabnzbd.appdata.xml -
This component contains no `developer` element with information about its author.
@Safihre I've added a patch on the Flathub package for the current package, so I'll wait till it get fixed in the next release. :)
https://github.com/flathub/org.sabnzbd.sabnzbd/blob/master/patches/sabnzbd-appdata.patch
Recently we've had users using flatpak and then run into issues where sab things they have no free space but in reality their /mnt are just read only. Any way to have our flatpak by default make /mnt read+write without having users to use flatseal?
@thezoggy See https://github.com/flathub/org.sabnzbd.sabnzbd/blob/master/org.sabnzbd.sabnzbd.yaml
This controls the r/w permissions, and the following are set by default:
- --filesystem=xdg-download
- --filesystem=/media
- --filesystem=/run/media
I can add more, as seen here: https://github.com/flathub/tv.kodi.Kodi/blob/3889b0f58ed02bc4f4b708d608c94294b5099248/tv.kodi.Kodi.yml#L14
You should have rw permissions to the Flathub repo, so you could also add them yourself. :)
However, I would encourage users to use something like Flatseal. Sometimes having full access to /mnt
is unwanted, but I'm happy to add more paths if requested. :)
Edit: done (flathub/org.sabnzbd.sabnzbd#41)