Giters

s00500 / ESPUI

A simple web user interface library for ESP32 and ESP8266

Home Page:https://valencia.lbsfilm.at/midterm-presentation/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ESPUI.server is now declared protected, previously public

benreu opened this issue · comments

commented

Describe the bug
ESPUI.server is now declared protected, used to be useful with AsynElegantOTA.begin( ESPUI.server )

To Reproduce
add this code to reproduce the behavior:

  1. #include <AsyncElegantOTA.h>
  2. AsyncElegantOTA.begin( ESPUI.server );
  3. Open your browser and go to http://IPAddress/update, where IPAddress is your ESP32 IP address.
    You will get the error: 'AsyncWebServer* ESPUIClass::server' is protected within this context

Expected behavior
AsyncElegantOTA used to work seamlessly with ESPUI

Desktop (please complete the following information):
All desktops

Smartphone (please complete the following information):
All smartphones

** Additional info: **
I moved the ESPUI server variable back to public in the ESPUI.h and everything works as expected. Should I make a Pull Request with this change, or is there something I am overlooking?

commented

I think we could expose it again, @MartinMueller2003 anything that speaks against that ?

commented

Fixed in PR:

Exposed WebServer, Added password support. #235