Slider in group not changing style dynamically
JD-GG opened this issue · comments
Bug
When changing the style of a slider in a slider-group using setElementStyle(uint16_t id, String style) it won't change dynamically and you have to refresh the page to see the changes.
Works fine when slider is not in a slider-group.
To Reproduce
Steps to reproduce the behavior:
- Make a slider-group
- Change the style of one slider with setElementStyle(uint16_t id, String style) during runtime
(i used ESPUI.setElementStyle(saturationSliderId, "background: linear-gradient(90deg, #ffffff 0%, #"+hex+" 100%);");) - See no change
- Refresh Page to see change
Expected behavior
Slider should have changed appearance dynamically.
Tried the same with a single slider and it changed color dynamically with the same function-call
Calling updateControl(uint16_t id) does not work and also already gets called in setElementStyle(uint16_t id, String style)
Desktop:
- OS: [WINDOWS]
- Browser [chrome, microsoft edge, opera]
Additional context
- AZ-Delivery ESP8266
Hmm, thanks, I'll have a look into this when I get a chance.
After further testing it seems to be the same reason as to why you can't dynamically update the visibility in a group.
Same as visibility it gets updated after the page is refreshed.
Note that the slider with the problem is not the Parent-Slider but a slider below that one.
The top slider changes style dynamically without problems with the same function call.
I just left a comment with regards to adding custom JS by code, and in this case if it existed, people could write little work arounds and "inject" them, just a thought!
Thanks!
Also seeing a similar issue when a slider value, other than the first in a group, is updated. It would appear this is down to the following line in slider.js ...
var number = parents.attr("id").substring(2);
...which causes a JS exception in the receiving browser...
Uncaught TypeError: parents.attr(...) is undefined
slider_move http://192.168.2.110/js/slider.js:11
handleEvent http://192.168.2.110/js/controls.js:36
start http://192.168.2.110/js/controls.js:51
onload http://192.168.2.110/:1
This hacky fix works for me, but doesn't feel right...
if (parents.attr("id")) {
var number = parents.attr("id").substring(2);
if (send) websock.send("slvalue:" + slider_new_val + ":" + number);
}
Sorry, not enough experience of how all this hangs together. Advice anyone?
Hi all, I am having trouble replicating this. I augmented my massive test program with a button to dynamically style a slider from a slider group using setElementStyle.
void groupSliderStyleCallback(Control *sender, int type) {
ESPUI.setElementStyle(groupsliders3, "background: red;");
}
It all seemed to work fine without a refresh.
Can I verify that you are both using the latest version of the library, the version from this repo?
@pcbbc if you look at the latest version of the minified controls.js then you'll see that it doesn't match up with your stack trace. Specifically handleEvent is called on line 50 of the current version but apparently 51 in yours.
@JD-GG same question to you. I think this is all fixed on the current version.
There should be no need to touch slider.js. Can I just verify @themindfactory that you are using the current version from this repo?
i.e. not whatever is in the Arduino library manager thing?
@iangray001 Yes, using the latest version. Sorry, I'd just inserted a line of debug at line 50 when I copied the exception trace.
My issue is slightly different from the bug report, so perhaps unrelated?
It concerns changing the second slider in a group, and the dynamical updating of that slider in the browser of another client. That other client does not update the second slider. It throws the exception.
Ahh so you're saying the issue is the second slider updating in another browser. Sorry, I missed that. I'll test that tonight.
@iangray001 I am 100% using the latest version. I recreated your example on multiple ESP8266. The 2nd and 3rd sliders are not changing dynamically. I am getting the following error on all my ESPs (same one as on my sketch)
void bCallback(Control *sender, int type) {
ESPUI.setElementStyle(sliderB, "background: red;");
}
- I used LITTLEFS to prepare all of them.
- I tried Opera and Firefox
What difference could there be between your and my tests? I can`t try it on a ESP32 because i don't own one.
Looks like the exact same stacktrace locations and error as my recreate.
See earlier post….
var number = parents.attr("id").substring(2);
You probably shouldn't just cut out bits of slider.js. All ESPUI elements have IDs of the format "xxNN" and so if slider_move is ever being called on an element where this isn't the case then something higher level has gone wrong.
However I still can't replicate this. Check this video, shows values and styles synchronising across multiple browsers in grouped sliders.
https://user-images.githubusercontent.com/7703247/170825624-8e0df856-a58f-41c8-9bce-b126dce55142.mov
Am I missing something?
You're both saying that you are using "the latest version" but I said "the current version from this repo? i.e. not whatever is in the Arduino library manager thing?".
As in, have you downloaded/cloned the code from this repo into the location where your libraries are manually?
If you open your version of controls.js is it identical to this one?
As in, have you downloaded/cloned the code from this repo into the location where your libraries are manually?
Yes.
If you open your version of controls.js is it identical to this one?
I manually copied the contents just to be sure.
Click on slider.js:11:609 and post the code underlined in red
.substring(2);if(send)websock.send("slvalue:"+slider_new_val+":"+number);}}
I manually copied the contents just to be sure.
Well this wouldn't help because that is just the source file. It is this file that is actually served (or the minified version if written into the filesystem). (Also, if you're doing that you need to rewrite the filesystem.)
Were they identical beforehand? The last commit changed line 654 to return; from switch (type) if it helps. Although I guess you've overwritten it now...
I presume you are using Arduino or PlatformIO, so remove the ESPUI library using their respective library managers, and then you'll know that you are using the files from this repo.
Were they identical beforehand?
I believe they were (because i downloaded the repo about 2 months ago).
Anyway i redownloaded everything and rewrote the FS.
Still doesn`t work :D (same err)
Interesting. So have you looked at my video? Does that look like it should recreate the issue you're seeing?
If so, can you prepare a minimal reproducible example please?
Sure thing :)
auto groupbutton = ESPUI.addControl(Button, "Button Group", "Button A", Dark, grouptab, aCallback);
ESPUI.addControl(Button, "", "Button B", Alizarin, groupbutton, bCallback);
ESPUI.addControl(Button, "", "Button C", Alizarin, groupbutton, cCallback);
void aCallback(Control *sender, int type) {
ESPUI.setElementStyle(groupsliders, "background: red;");
}
void bCallback(Control *sender, int type) {
ESPUI.setElementStyle(sliderB, "background: red;");
}
void cCallback(Control *sender, int type) {
ESPUI.setElementStyle(sliderC, "background: red;");
}
bigTest.mp4
Oh for fuck's sake...
Well I've worked out why I can't recreate either of your bugs. I fixed it back in February, on my development repo and forgot to create a pull request to push the fix back here. Sorry!
Yes @themindfactory you are right. That was the issue and (nearly) the fix. Ah well silly me. I'll actually get this commit merged in.
Thank you both for all your help, sorry I made everything take longer by being an idiot :)
Not at all. It’s not always easy! Thanks for the fix.
"It works on my machine ¯\_(ツ)_/¯"
Thank you for your time :D