memcached plugin for infrataster

Question

memcached plugin for infrataster

rahulkhengare opened this issue 9 years ago · comments

Currently I am working on testing database servers in combination with memcached servers using infrataster.

Memcached:
Memcached is an in-memory key-value store for small chunks of arbitrary data.
For more details about memcached refer,
http://memcached.org/

I am planning to develop memcached plugin for infrataster. This plugin used to query memcached server to check the statistics of server, set and get the values from server.

This plugin will useful for other users also.
Please share your thoughts.

Ryota Arai · Answer 1 · Tue Mar 03 2015 22:14:18 GMT+0800 (China Standard Time)

memcached plugin is very good idea.
If you create the one, please tell me that. I'll add it to README.

Rahul Khengare · Answer 2 · Mon Mar 09 2015 16:54:02 GMT+0800 (China Standard Time)

I have implemented plugins for memcached server, the plugin is tested on linux machine.

Plugin Source:
https://github.com/rahulkhengare/infrataster-plugin-memcached

Kindly review the plugin.
Your thoughts and suggestions will be greatly appreciated

Ryota Arai · Answer 3 · Mon Mar 09 2015 17:42:46 GMT+0800 (China Standard Time)

I think this global variable is dirty for namespace and instance or class variables is better.

The plugin looks good to me except the point I mentioned.

Rahul Khengare · Answer 4 · Mon Mar 09 2015 20:47:15 GMT+0800 (China Standard Time)

Thanks for review.

I have changed the code as per review comments. I converted global variable into instance variable.
Kindly have a look.

Commit Link:
rahulkhengare/infrataster-plugin-memcached@05b7fdf

Ryota Arai · Answer 5 · Mon Mar 09 2015 21:26:57 GMT+0800 (China Standard Time)

It looks good to me! I'll introduce your plugin in README.

Rahul Khengare · Answer 6 · Mon Mar 09 2015 22:39:15 GMT+0800 (China Standard Time)

Thank you very much for including memcached plugin.
I really appreciate it.