Giters

rygelouv / android-audio-sensei

High-level library to make android audio recording and playing more simple by handling boring stuff like runtime permissions and by completely abstracting audio playback controller

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Audio Stop Playing on RecyclerView Scroll

ravinderparihar opened this issue · comments

commented

Hi,
I am using AudioSenseiPlayerView in RecyclerView for multi audios but when i am scrolling RecyclerView, it stop playing audio, please describe how can i keep playing clicked audio on RecyclerView Scroll?

commented

Hi @ravinderparihar i did not noticed that. Thank you for your feedback. Let me think dig into it a litter deeper and fix that as soon as possible. Stay tuned. Thank you again

commented

Hi Rygel Louv,
Thanks to notice, have you got any solution regarding above issue?

commented

Yes, working on applying a fix. Will publish a new version later today.

commented

Rygel Louv,

Thank you so much for your efforts and communication, please update when done.

commented

@ravinderparihar i just published a new version (0.1.1) that fixes the problem. Please check the readme file, try it out and let me know.
Be careful about the dependency name though, it moved from 'com.github.Rygelouv:android-audio-sensei:v0.1.0-beta' to 'com.github.rygelouv:android-audio-sensei:0.1.1'.

You must also add this line in your activity/fragment onCreate or onCreateView for fragment:
AudioSenseiListObserver.getInstance().registerLifecycle(getLifecycle());

Check the documentation https://github.com/rygelouv/android-audio-sensei#using-with-recyclerview

Waiting for your feedback.

commented

Thanks Rygel Louv,
It's done now playing while scroll, but now stop playing while screen go's on sleep or in hibernate mode, please check I appreciate your efforts, thank you so much in advance.

commented

Rygel Louv,
On thing i want to suggest that, can you show progress bar while it fetching audio from server and the progress values of song below the seek bar, so that it will be more friendly with users, it is an suggestion if you can, thank you.

commented

Hello @ravinderparihar sorry for the late response. I was a little busy these past days.
If the audio stops playing while screen goes on sleep isn't it a good thing ? I can figure out to make it configurable so you can choose the behavior that you want.

Will come up with something soon
Thank you very much for your feedback.

commented

ok thanks

commented

app in background keep crashing, please do something as soon as you can, either i have to change the dependency or have to find other solution.

commented

Could you give some more insight please ?

commented

@rygelouv I think that @ravinderparihar is asking for more than this library is built for. The library in it's current state is amazing and you should be proud of the work you've done. The only feedback I'd have is perhaps improving the stock UI a tiny bit but even that is just being picky.

You've made an awesome library that's saved me a tonne of time.

commented

@bstillitano thank you very much. I really appreciated it. And you guys are right. I'm currently quite busy with work. But i'm preparing to get a V2.0 of this library. I need to review everything, rewrite some parts of the code add some additional features and just like you suggest, I will improve the stock UI.

commented
commented

I sure will

commented

can i play audio from url

commented

@abdellatifab working on it. Sorry I don't put much time in this library anymore but I'm for sure preparing for a new release.