ryersondmp / sa11y

Sa11y is an accessibility quality assurance tool that visually highlights common accessibility and usability issues. Geared towards content authors, Sa11y straightforwardly identifies errors or warnings at the source with a simple tooltip on how to fix them.

Home Page:https://sa11y.netlify.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dark Mode colour filter

brianteeman opened this issue · comments

Clearly the dropdown has a problem when in dark mode

image

Weird, only happening in Windows. I'll look into it, thanks!

What browser & OS combo are you using?

chrome, windows 11

Weird. I tested with Firefox, Edge, Chrome and Opera on Windows 11 via BrowserStack, and this doesn't happen. Maybe if i explicitly set the background colour to the panel colour it can fix this.

when you tested were you changing everything (browser) to dark mode or just sa11y?

BrowserStack doesn't seem to support changing browser or system to dark theme — they only support increasing system contrast.

For now, i'll explicitly set the background to the panel background colour, because right now it's set to background: none; — should hopefully fix it.

Please test this again when you get a chance

I had a colleague test on Windows 11 with system dark mode enabled. Appears to be fixed

Colour filter select menu with proper contrast.