Giters

ryanwalters / sticky-events

Events for `position: sticky`

Home Page:https://ryanwalters.github.io/sticky-events/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't read property top of null

ryanburnette opened this issue · comments

commented

I'm getting a lot of can't read property top/height of null errors.

demo: https://codepen.io/ryanburnette/pen/gerKQP

screen shot 2018-03-15 at 12 32 19 am

I was originally setting up the issue to show that if an element is pushed down by content above it the events fire as if the element were positioned where it would be if that "pushing" content were not there. If it were working you could test that by adding and removing paragraphs of content above the box.

commented

There seems to be an issue with IntersectionObservers in iframes. w3c/IntersectionObserver#183

The error occurs because IntersectionObserverEntry.rootBounds is returning null instead of DOMRectReadOnly.

I'm going to close this for now, since I don't think there's anything on my side that I can fix at the moment.

commented

@ryanburnette As a side note, v1.3.1 should fix your "original" issue (unrelated to the null errors) where the sticky element was sticking at the wrong time when there was content above the sticky element. Thanks for pointing these out!