Increase in FA icon size 3.2.0 to 3.2.1
Finii opened this issue · comments
Apologies if this is unrelated or intended, but I noticed an increase in the size of some symbols in ttf-firacode-nerd, going from 3.2.0 -> 3.2.1 in my i3 status bar.
3.2.0 |
3.2.1 |
|---|---|
 |
 |
U+F120 (nf-fa-terminal) and U+F11B (nf-fa-gamepad)
Originally posted by @martinpelikan in #1611 (comment)
A lot glyphs changed size, but why? 😬 😆
Ah here, it seems to be intended
1fe5837 FontAwesome: Scale glyphs a bit bigger
Which is part of
Lets compare the glyphs
You see, a lot glyphs got smaller on v3.1.1 -> v3.2.0 and grew back to a comparable size on v3.2.1.
For some other glyphs they stayed the same from v3.1.1 to v3.2.0 and now only grew with v3.2.1. But they usually also changed the outline (i.e. look different anyhow).
I don't know. The icons all changed with the substantial update from FA 4.7 (2016) to FA 6.5.1 (2024). The relative to each other sizes changed. It is hard to know what is now 'right'. In total the FA of our v3.2.0 was a bit on the small size (got reported) - not for all but for a lot icons. That was the reason to lift the size a bit.
Do you think the icons are now too big?
Sizewise I would look at v3.1.1 and v3.2.1, as v3.2.0 just lived 2 weeks or so.
Thank you for the very quick investigation and detailed response!
Do you think the icons are now too big?
From the perspective of my tiny use case, yes, but possibly because I grew used to the previous size. I'm not sure I would notice had they not overflowed the fixed size I had configured, something I can easily change.
I think I prefer the previous size because the line weight/thickness appears consistent with other symbols I use, but I haven't compared against many others. I wouldn't push for further changes if others are happy with where things are at.
Here's a comparison of the versions you mentioned:
3.1.1 |
3.2.1 |
|---|---|
 |
 |
Also speaking from my personal use case, I find the increase in size makes FA icons difficult to integrate with icons from other sets.
I use U+F015 (nf-fa-home) with U+E725 (nf-dev-git_branch) for my prompt, and U+F057 (nf-fa-times_circle) and U+F05A (nf-fa-info_circle) with U+F0028 (nf-md-alert_circle) and U+F02D7 (nf-md-help_circle) for diagnostics. A before-and-after comparison:
3.1.1 |
3.2.1 |
|---|---|
 |
 |
 |
 |
Personally, I preferred the old size, but if the change was necessary I can switch to icons from other sets without problem.
@treequin What are these secondary circles in the bottom picture? They are not important I guess?
I guess this needs are more systematic approach 😬 Thanks for the input.
@treequin What are these secondary circles in the bottom picture? They are not important I guess?
I'm not sure I understand, do you mean the zeros? They're just the number of diagnostics of each type in the document (I took the screenshot on an empty file).
the zeros?
🤦♀️
Yes. Thanks! 😺