ryangball / DockBuilder

A LaunchAgent and .app to build a user's Dock upon login and/or on demand.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add a Loop for Mojave and Catalina

ZJPat opened this issue · comments

commented

Hello Since Catalina moved System Preferences to /system, can you please add a loop to check if its 10.14 or below to add System Preferences from Applications otherwise add it from /system/Applications.

Thanks

I think it would be simpler to add logic to dockbuilder.sh at around lines 38 and 38 to check for the existence of $item before adding the dock item. It would enable us to have lists both the Catalina paths and the pre-Catalina paths; dockbuilder would only try to add the "correct" paths and skip items that do not exist.

if [ -e "$item" ]; then
/usr/local/bin/dockutil --add "$item" ...
fi