Empty message content throws E_MISSING_MESSAGE

Question

Empty message content throws E_MISSING_MESSAGE

mateubo opened this issue 7 years ago · comments

Hi,
cldrjs get method throws E_MISSING_MESSAGE error when message content is an empty string.
{ "someProp": "" }.
I'm aware that an empty string is a "falsy" value, but still, it is a valid message content and it should be returned.

Rafael Xavier de Souza · Answer 1 · Mon Jul 03 2017 20:09:17 GMT+0800 (China Standard Time)

That might be a globalize thing since cldrjs doesn't throw that error.

Rafael Xavier de Souza · Answer 2 · Mon Jul 03 2017 20:09:26 GMT+0800 (China Standard Time)

Please, could you file an issue there?

Mateusz Bożyk · Answer 3 · Mon Jul 03 2017 20:34:19 GMT+0800 (China Standard Time)

Ah, sorry, the error is indeed thrown by globalize, but the problem is in cldrjs, specifically src/item/lookup.js and quite general if statements there that treat undefined, null, "" in the exactly the same way.

Rafael Xavier de Souza · Answer 4 · Mon Jul 03 2017 20:58:51 GMT+0800 (China Standard Time)

Oh, ok. Reopening then... It indeed should return undefined if the path doesn't exist, but the actual value otherwise. Feel free you like to submit a PR and thanks!

Mateusz Bożyk · Answer 5 · Wed Jul 12 2017 11:55:08 GMT+0800 (China Standard Time)

Hi, I submitted a PR for this issue, would you consider accepting it and deploying a new release?

Rafael Xavier de Souza · Answer 6 · Wed Jul 12 2017 21:37:41 GMT+0800 (China Standard Time)

Sorry for the delay, just reviewed it.

Mateusz Bożyk · Answer 7 · Fri Jul 21 2017 13:04:05 GMT+0800 (China Standard Time)

I'm sorry for pushing this - I know we are in the middle of the holiday season, please review an updated PR whenever you have the time. Thanks!