Handle unicode variant subtags on likelySubtags and removeLikelySubtags

Question

Handle unicode variant subtags on likelySubtags and removeLikelySubtags

rxaviers opened this issue 9 years ago · comments

Rafael Xavier de Souza commented 9 years ago

Since variant subtags are not being handled on likelySubtags, the minlanguageId of en-US-POSIX is wrongly en instead of en-POSIX leading to wrong bundle lookup. Similarly for maxLanguageId.

Dan Polivy · Answer 1 · Wed Jul 22 2015 02:15:15 GMT+0800 (China Standard Time)

@rxaviers Any workarounds for this? I'm getting bitten by this issue since we're loading the full data set, and my en numbers aren't being formatted correctly. (Note: I am using the setAvailableBundles 'hack' as we've previously discussed.)

Rafael Xavier de Souza · Answer 2 · Wed Jul 22 2015 19:22:36 GMT+0800 (China Standard Time)

This is supposed to be an easy fix... Although, it will take me a while to work on it. Help appreciated. Basically, the files that need fix are likelySubtags and removeLikelySubtags (with special attention to the instruction of the lines I've highlighted). This may also help: subtags. Both likelySubtags and removeLikelySubtags are used in bundle loopup (root of the problem) and also in init.

Tests need to be included to assert this fix.

Rafael Xavier de Souza · Answer 3 · Mon Jan 18 2016 20:22:08 GMT+0800 (China Standard Time)

@patch, FYI this is fixed.

Nova Patch · Answer 4 · Mon Jan 18 2016 23:10:37 GMT+0800 (China Standard Time)

@rxaviers 🎉 Thanks! I’ll test this out.

Rafael Xavier de Souza · Answer 5 · Tue Jan 19 2016 00:38:42 GMT+0800 (China Standard Time)

Released in 0.4.4.