Enhancement: Migrate React.PropTypes to use prop-types package for React 15.4
rwieruch opened this issue · comments
The newest version of React extracts PropTypes to its own library. It would be cool to use the new library. In a sibling project the refactoring was already done: rwieruch/favesound-redux#42
@rwieruch Hi, I have already created a pull request for this issue, however there is a new problem:
According to the documentation of prop-types:
It seems like one of the package is using the old syntax but I am not sure which one. Could you give me some hint please?
Hi @field0917 Thanks for your PR! I would assume, since it uses the same libraries than https://github.com/rwieruch/favesound-redux except for mobx and mobx-react that the warning could come from one of these libraries? In another PR it could be worth a shot to upgrade the mobx-react library, even though I am unsure about the recent breaking changes that will come with the upgrade.
Nevertheless, I assume that I can merge the PR, because only the Warning shows up? The mobx-react library upgrade could be another PR. Thanks for your help!
@field0917 I upgraded the library versions, but I am still seeing the Warning :( b79f548
I'll try to fix this warning later today.
Yes, give it a shot @field0917 Nevertheless, the PR got merged
The above issue was caused by the inconsistency of React(15.0.x) and prop-types(15.5), I'll create a PR to upgrade React version to 15.6.x.
After upgrading react, these warnings will come up:
I think it could be caused by react-router@3.0.0, since we have already migrated our source code to prop-types, I'll try to migrate react-router to the latest version and see how it goes.