rwieruch / favesound-mobx

🎶 A SoundCloud Client in React + MobX running in production. Live Demo and Source Code to explore React + MobX. Refactored from favesound-redux

Home Page:http://www.robinwieruch.de/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

if login rejected

milon87 opened this issue · comments

I was checking live demo. after login button press it was trying to navigate to the dashboard but login was not successful. so it was stuck in the dashboard with a loading indicator.

I think if login rejects/cancel then it will show only home page.

Yes. I have seen this issue too.

Apparently it is also an issue in https://github.com/rwieruch/favesound-redux I wouldn't want to diverge both repositories too much from each other. If it keeps being an issue for people, it would be great to address it first in the big brother favesound-redux project.

@rwieruch I have created a PR for this issue in favesound-redux.

@rwieruch Do you think I should also update this repo too to keep it in sync with favesound-redux?
rwieruch/favesound-redux#77

If you have the time, I think it would be great to keep them in sync :)
This one can be closed right?

@rwieruch Sure, I'll do it. I think it could be closed afterward.