rwengine / openrw

OpenRW "Open ReWrite" is an un-official open source recreation of the classic Grand Theft Auto III game executable

Home Page:http://openrw.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Instances of std::shared_ptr<Menu> can be replaced with std::optional<Menu>

opened this issue · comments

As debug state is clear owner of these, there is no need for std::shared_ptr.

Furthermore (with available now c++17) it's possible to avoid dynamic memory allocation and reduce overhead.