rust-lang / rustc-perf

Website for graphing performance of rustc

Home Page:https://perf.rust-lang.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Vertical dotted line in 30 day history makes it hard to see data value

pnkfelix opened this issue · comments

I love the addition of the 30 day graph to the benchmark detail that I now see in the compare page. It really helps provide some much needed context when trying to interpret some result that's been flagged.

However, the current interface highlights the specific commit under comparison with a dotted line that obscures the actual data value in the 30 day view, as shown here:

image

(In the above somewhat zoomed in view, you can make out where there are gaps in the dottted line and thus infer a rough idea of where the value lies. But in my web browser, a bit more zoomed out, its harder to tell for sure where the value was...)

I'm torn about this: Its a really good idea to highlight where the commit lies.

but can we do it in a way that doesn't obscure the value its been assigned? Maybe can we put a short horizontal line-segment that intersects this vertical line at the place corresponding to the measured value for the commit? (Or maybe even just choose a different color for the dotted line, like blue or something?)

Hi, you're right, the current line obscures data too much. @lqd wants to change the background tint of the "future part" of the graph, that should make it less obscuring.