Exit code 0 with build errors

[Jorge Leitao]

The command mdbook build returns exit code 0 when there are errors. This hides failed builds in CI builds (among others).

Could it make sense to exit non-zero on builds with errors, so that e.g. - run: mdbook build on CI fails?

[Eric Huss]

Can you share the output of the error message? mdbook build should usually return a nonzero exit code.

[Jorge Leitao]

Thanks! This build: https://github.com/jorgecarleitao/arrow2/runs/8298204019?check_suite_focus=true (called with - run: mdbook build guide on latest mdbook: https://github.com/jorgecarleitao/arrow2/blob/docs/.github/workflows/docs.yml

[Jorge Leitao]

It seems that it silences errors from Rust snippets?

[Eric Huss]

Ah, I see. I believe this is a duplicate of #1094, so closing in favor of that.