compiletest failures don't fail CI
jonas-schievink opened this issue · comments
Jonas Schievink commented
The compiletest suite requires nightly, but Travis is configured to allow_failures
on nightly. They are essential to test soundness, so this is not good.
Jonas Schievink commented
Luckily the only failures I see are due to wording changes in error messages
Jonas Schievink commented
It might make sense to move these tests over to trybuild and run them only on the current stable instead of nightly.
Jonas Schievink commented
It looks like trybuild will only run cargo check
, and can not be coerced to actually codegen and link, which is required by some tests to detect duplicate symbols. Luckily compiletest
should now also run on stable though.