Error when dumping channel with files, when there are files that was deleted.
svantek-admin opened this issue · comments
Describe the bug
When doing dump of Slack channel which downloading files I get following error
error saving "XXXXXXXXXX-" to "aaaaa/attachments": callback error: download to "aaaaa/attachments/XXXXXXXXXX-" failed, [src=]: received empty download URL
it seems that when there were file in message but later was deleted, slack returns array with file which "mode": "tombstone"
When this happens, malformed URL is added in exported file
"url_private": "attachments/XXXXXXXXXX-",
"url_private_download": "attachments/XXXXXXXXXX-",
To Reproduce
Steps to reproduce the behavior:
- Create channel in slack
- Upload file
- Delete this file
- Run slackdump -download on this channel
Expected behavior
No attempt to download file is performed
Desktop (please complete the following information):
- OS: Linux
- OS Version: Ubuntu 22.04
- Slackdump Version: 2.5.4
Hey @svantek-admin, thanks for the report, I thought tombstones are handled in the code, but I'll double check.
@svantek-admin, this is fixed now, sorry for the inconvenience. I did handle tombstones, but in the dev (v3) branch ¯\_(ツ)_/¯