Attachments downloaded in standard export although no -download flag
jo-chemla opened this issue · comments
Describe the bug
When doing a standard export, then attachments are downloaded although there is no additional -download
flag in the command.
To Reproduce
Steps to reproduce the behavior: Run slackdump like this
slackdump -export my-workspace -export-type standard
Expected behavior
Attachments should not be present.
Desktop (please complete the following information):
- OS: windows
- slackdump version: latest v2.4.1
Note it might as well be useful for slackdump to allow for the download of all attachments or only these present in private channels/DMs - not these present in public channels. Maybe via a flag like -download [all (default) | private-only | public-only]
Hey @jo-chemla this is expected behaviour, and a design flaw: have a look at this #227 where I explained why this happens.
Also, thank you for a great suggestion of the download behaviour, I'll create a separate issue for it.
Thanks for getting back! I also did not notice the no-download behavior - maybe the doc could clarify there are these 3 modes
- nodownload (don't specify anything)
- standard (add
-export-type standard
) - mattermost (add
-export-type mattermost
)
V3 will have updated logic, and this won't be necessary, I just need to find some time to finish it 😂