rurban / Cpanel-JSON-XS

Improved fork of JSON-XS

Home Page:http://search.cpan.org/dist/Cpanel-JSON-XS/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Subroutine JSON::PP::Boolean::(++ redefined" with newer perls

ntyni opened this issue · comments

Hi,

we're seeing this with Perl 5.36 and newer:

$ /opt/perl/bin/perl5.37.3 -w -e 'use Cpanel::JSON::XS (); use JSON::PP'
Subroutine JSON::PP::Boolean::(++ redefined at /opt/perl/lib/5.37.3/overload.pm line 52.
Subroutine JSON::PP::Boolean::(0+ redefined at /opt/perl/lib/5.37.3/overload.pm line 52.
Subroutine JSON::PP::Boolean::(-- redefined at /opt/perl/lib/5.37.3/overload.pm line 52.

This is with Cpanel::JSON::XS 4.31 and JSON::PP 4.10 or 4.11. Apologies if Cpanel::JSON::XS is not the one to blame :)

The warnings are breaking at least the Request Tracker test suite, as discussed in https://bugs.debian.org/1016806 .

Apologies, I didn't test with newer perl's.
Yes, I am to blame.
I made the overload mess now better, skipping duplicate overloads at all.

Finally fixed with 4.32