rurban / Cpanel-JSON-XS

Improved fork of JSON-XS

Home Page:http://search.cpan.org/dist/Cpanel-JSON-XS/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Newly introduced test 125_shared_boolean.t requires threads::shared 1.21

ribasushi opened this issue · comments

As per subject - the test needs to check for minimum version of t::s, and skip_all if not available.

Failure without this:

Undefined subroutine &main::shared_clone called at t/125_shared_boolean.t line 14.
# Looks like your test exited with 255 before it could output anything.
[06:52:22] t/125_shared_boolean.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 8/8 subtests 

Thanks!

This affects all perls at or before 5.10.0.

This affects all perls at or before 5.10.0

Only with its pristine libs, never updated. Which nobody should do. Otherwise I would have detected it in my smoke testing with all Perl versions.

Ah indeed, I had not realized (having not ever really used threads much) that threads::shared is dual-life rather than core only.

Fixed with 4.22/4.23