feat: add new design for search results page (no results found)
Anmol-Baranwal opened this issue · comments
You can view the figma file here.
The design should be responsive.
ℹ️ We recommend updating the styling of existing components, otherwise you can add extra components if there is a need.
- You need to implement the above design.
Any changes to the above design are welcome. Please feel free to share your thoughts, and we will discuss them thoroughly.
⚠️ Make sure to push all the changes into dev branch
To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.
Hello Anmol-Baranwal!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊
Please make sure to follow our Contributing Guidelines. 💪🏻
Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!
Can I work on this and? @rupali-codes @Anmol-Baranwal
@SandeepGumaste
I have assigned you the issue. Please proceed with it, and don't hesitate to tag maintainers if you require any assistance.
Also, remember to switch to dev mode. It will be easier for development.
Top right corner in figma file
Didn't find the search icon in react-icons which is already used in the project and also couldn't download the icon from figma because export is enabled only for editors. Are the icons used in the new ui are from some icon pack that I can install? @Anmol-Baranwal @rupali-codes
Didn't find the search icon in react-icons which is already used in the project and also couldn't download the icon from figma because export is enabled only for editors. Are the icons used in the new ui are from some icon pack that I can install? @Anmol-Baranwal @rupali-codes
Wait, giving you the icon. The icon pack used is react-icons. You can use local icon when provided by us.
@SandeepGumaste
You can now export the icons and use it. It's properly working.
@SandeepGumaste any updates? Are you still willing to work on this?
Will submit a pull request in some time today. @rupali-codes
Will submit a pull request in some time today. @rupali-codes
Hey @rupali-codes can I jump on this?
Hey @rupali-codes can I jump on this?
You're assigned @heysolomon! :)
Hey @rupali-codes can I jump on this?
You're assigned @heysolomon! :)
okay thank you!
Completed with #2224.