Failures when asserting array elements in json response

Question

Failures when asserting array elements in json response

mujx opened this issue 8 years ago · comments

I had some failures with sync::can_sync_a_room_with_a_single_message, here is particular.

The order of the elements in a json array is not guaranteed (I think is alphabetical) so we shouldn't use next to test the existence of the EventIds.

Jan Jansen · Answer 1 · Thu Dec 29 2016 23:56:43 GMT+0800 (China Standard Time)

The Order of the array is important.
Possible we need to add a order to sql statement. I can lookup the spec later. This array represents the timeline.

mujx · Answer 2 · Fri Dec 30 2016 00:08:43 GMT+0800 (China Standard Time)

I added more events, and it works fine. Still can't figure out what caused the failures.

mujx · Answer 3 · Fri Dec 30 2016 00:36:46 GMT+0800 (China Standard Time)

I am closing this since I can't reproduce. It was probably an one time thing during development.

mujx · Answer 4 · Fri Dec 30 2016 22:37:06 GMT+0800 (China Standard Time)

I am re-opening because the travis build failed with this error.

Jan Jansen · Answer 5 · Mon Jan 02 2017 04:08:36 GMT+0800 (China Standard Time)

I think my implementation of sync is incorrect. This need to be test more.