Giters

rudikershaw / git-build-hook

A maven plugin for managing client side (local) git configuration for those working on your project. Including but not limited to setting git config, installing hooks, validating the local repository.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

threadsafe

delanym opened this issue · comments

commented

Pls mark as @threadsafe to support parallel building to avoid this warning

[WARNING] *****************************************************************                                                                                                                                   [WARNING] * Your build is requesting parallel execution, but project      *                                                                                                                                   
[WARNING] * contains the following plugin(s) that have goals not marked   *                                                                                                                                   
[WARNING] * as @threadSafe to support parallel building.                  *                                                                                                                                   
[WARNING] * While this /may/ work fine, please look for plugin updates    *                                                                                                                                   
[WARNING] * and/or request plugins be made thread-safe.                   *                                                                                                                                   
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in Traderoot Maven Super:
[WARNING] com.rudikershaw.gitbuildhook:git-build-hook-maven-plugin:3.1.0
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************
commented

Hi @delanym,

I can certainly take a look to see what changes are required for me to confidentially mark it as thread safe. There are some goals for example that have file system operations that I would not be comfortable marking as thread safe.

commented

@rudikershaw do you think the functionality provided in this plugin might be better suited to an extension with a config file?

commented

I have marked the initialize and configure goals as thread safe, and released the changes to 3.2.0. The install goal cannot be trivially made thread safe, and so it has not be marked as such.