Deactivation switch for ANSI color

Question

Deactivation switch for ANSI color

trans opened this issue 13 years ago · comments

7rans commented 13 years ago

There needs to be a way to globally deactivate ANSI coloring.

7rans · Answer 1 · Sat May 07 2011 23:24:02 GMT+0800 (China Standard Time)

Should this effect all codes including moving the cursor, or just effect colorization codes?

7rans · Answer 2 · Thu Nov 10 2011 08:39:59 GMT+0800 (China Standard Time)

This has been implemented with $ansi global variable. It will work in almost all cases. But there are still a few edge cases that will need address in the future, and also it doesn't effect BBCode yet b/c that lib still needs to be fully integrated with ANSI::Code.

7rans · Answer 3 · Wed Jan 07 2015 01:03:28 GMT+0800 (China Standard Time)

It has been pointed out to me that it would probably be better if a global wasn't set by default. For that to work there are two options.

Either $ansi = nil would have to be equivalent to $ansi = true and only setting it specifically to false would deactivate it. That'll work but it is a bit odd to have nil === true.
Or we need to use a $noansi (or $no_ansi) global instead.

Both cases may cause backward compatibility issues --the later more so than the former. So does the benefit out way the downside of change?