rubysec / ruby-advisory-db

A database of vulnerable Ruby Gems

Home Page:https://rubysec.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Pre537] Omit or replace patched_versions field during lib/github_advisory_sync.rb run if it was never patched

jasnow opened this issue · comments

Omit or replace patched_versions field during lib/github_advisory_sync.rb run if it was never patched.
Currently, here is the the results of lib/github_advisory_sync.rb script:

gems/arabic-prawn/CVE-2014-2322.yml:patched_versions:
gems/arabic-prawn/CVE-2014-2322.yml-- ">= "

Normally I add a notes: "ever patched" where patched_versions would be if never patched.

Probably overlaps some with #157.

@jasnow if there's no patched-versions, would you prefer that the patched_versions: be omitted entirely, or left empty?

@jasnow if there's no patched-versions, would you prefer that the patched_versions: be omitted entirely, or left empty?

My vote for no patched_version: value is to replace it with:

notes: "Never patched"

so the future me will know explicitly that someone checked and did not find a patched version.

My vote for no patched_version: value is to replace it with:

notes: "Never patched"

Sort of like the way cvss_v3 is implemented:

 "cvss_v3"             => ("<FILL IN IF AVAILABLE>" unless cvss),

#664 should resolve this.

#664 should resolve this.

Agree