Deprecation warning emitted from Thor
lopopolo opened this issue · comments
Ryan Lopopolo commented
Description
bundler-audit
emits a deprecation warning from Thor if given invalid extra arguments.
Steps To Reproduce
Steps to reproduce the bug:
$ bundle exec bundler-audit check --update format foo
ERROR: "bundler-audit check" was called with arguments ["format", "foo"]
Usage: "bundler-audit check [DIR]"
Deprecation warning: Thor exit with status 0 on errors. To keep this behavior, you must define `exit_on_failure?` in `Bundler::Audit::CLI`
You can silence deprecations warning by setting the environment variable THOR_SILENCE_DEPRECATION.
$ bundle exec bundler-audit version
bundler-audit 0.8.0
Expected Behavior
bundler-audit
does not emit deprecation warnings from its dependencies.
Actual Behavior
ERROR: "bundler-audit check" was called with arguments ["format", "foo"]
Usage: "bundler-audit check [DIR]"
Deprecation warning: Thor exit with status 0 on errors. To keep this behavior, you must define `exit_on_failure?` in `Bundler::Audit::CLI`
You can silence deprecations warning by setting the environment variable THOR_SILENCE_DEPRECATION.
Environment
$ bundle exec bundler-audit --version
bundler-audit 0.8.0
$ bundle --version
Bundler version 2.2.22
$ ruby --version
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-darwin20]
Postmodern commented
Fixed in 0.9.0.