ruby / setup-ruby

An action to download a prebuilt Ruby and add it to the PATH in 5 seconds

Home Page:https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider BUNDLE_ONLY in cache key

r7kamura opened this issue · comments

BUNDLE_ONLY has been added since bundler 2.3.19.

I think this value should be included in the cache key as well as BUNDLE_WITH and BUNDLE_WITHOUT, what do you think?

setup-ruby/bundler.js

Lines 235 to 239 in 52b8784

async function computeBaseKey(platform, engine, version, lockFile, cacheVersion) {
const cwd = process.cwd()
const bundleWith = process.env['BUNDLE_WITH'] || ''
const bundleWithout = process.env['BUNDLE_WITHOUT'] || ''
let key = `setup-ruby-bundler-cache-v6-${common.getOSNameVersionArch()}-${engine}-${version}-wd-${cwd}-with-${bundleWith}-without-${bundleWithout}`

Yes, that makes sense, could you make a PR for it?

Thanks for your quick reply. I created the following pull request for this 👌

When will this be tagged?