ruby / rexml

REXML is an XML toolkit for Ruby

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Could you set required_ruby_version >= 2.1? Latest 3.2.5 release is broken on Ruby 2.0

ivoanjo opened this issue · comments

Hello there!

I'm one of the maintainers for @DataDog's ddtrace gem. We still support customers running Ruby 2.0, and run our CI with Ruby 2.0 as well.

We've noticed that the latest 3.2.5 release no longer works on Ruby 2.0. Of course, it doesn't make any sense to ask upstream to still support Ruby 2.0 (good riddance), but I'd like to ask for two things:

  1. Could you add required_ruby_version = '>=2.1' (or some later version) to the gemspec and release a 3.2.6 with that change?
  2. Could you yank version 3.2.5, so that bundler doesn't try to install it on older rubies?

Thanks a lot, and let me know if there's anything I can help with to make this move faster :)

@ivoanjo Would you like to offer a PR with that change?

Sure, I'll whip up a PR in a few minutes!

PR opened #70 . Would be really nice if this could get released quickly! (Would save me from having to hack a workaround on our CI 😭 )