Handling of macro methods with optional parenthesis

[Andy Waite]

For macro methods, parentheses are usually optional, which results in quite different ASTs, e.g. for

test "it does something" do
  a = 1
  assert true
end

the AST is:

(program
  (statements
    ((command
        (ident "test")
        (args ((string_literal ((tstring_content "it does something")))))
        (block (bodystmt (statements ((assign (var_field (ident "a")) (int "1")), (command (ident "assert") (args ((var_ref (kw "true")))))))))))))

but with test("it does something")

(program
  (statements
    ((method_add_block
        (call nil nil (ident "test") (arg_paren (args ((string_literal ((tstring_content "it does something")))))))
        (block (bodystmt (statements ((assign (var_field (ident "a")) (int "1")), (command (ident "assert") (args ((var_ref (kw "true")))))))))))))

This means it's necessary to implement both visit_command and visit_method_add_block.

@Morriar suggested exploring if there could be a common ancestor so that only a single visit_ would be needed.

[Kevin Newton]

Yeah for sure. This is part of my backlog to unify the call nodes, which is part of the larger ticket of using the YARP AST instead of the current one.

[Andy Waite]

Thanks @kddnewton, feel free to close this if it's already planned.

[Kevin Newton]

Thanks @andyw8 yeah I'll go ahead and close this for now.