Giters

ruby-oembed / ruby-oembed

oEmbed for Ruby

Home Page:http://oembed.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

OEmbed::Providers.register_all() does not register all provided providers

vanto opened this issue · comments

commented

Currently, register_all is defined as follows:

def register_all
  register(Youtube, Flickr, Viddler, Qik, Revision3, Hulu, Vimeo)
end

The following providers are defined in the same file but are not registered:

  • Instagram
  • Slideshare
  • Yfrog
  • MlgTv

I guess they should be included so I suggest to simply add them to the register_all method, e.g. like this:

def register_all
  register(Youtube, Flickr, Viddler, Qik, Revision3, Hulu, Vimeo, 
           Instagram, Slideshare, Yfrog, MlgTv)
end
commented

Yeah, I agree that it's a bit of a misnomer. Probably worth updating.

commented

+1 can we get this in the gem thanks!

commented

Alright, you convinced me... working on it. There are a few little changes that have been piling up so I'll do my best to get a new gem version released soon. Perhaps this weekend.

commented

That would be awesome! Lets us know when the new gem is published. Thanx man.

commented

As you've probably noticed the release didn't make it out this weekend :-( I've got the changes pretty much wrapped up locally, and will close this ticket once the new gem is released.

commented

Grab version 0.8.7 of the ruby-oembed gem to take advantage of the new and improved OEmbed::Providers.register_all method.

commented

A potential problem is an inconsistent typo (agregation vs. aggregation).

commented

@vanto hehheh, I guess that's the problem with open source & version control, I get to show off my inability to spell aggregator to the world. After searching through the code-base I found:

  1. 5 occurrences of "aggregator(s)", 4 of which were documentation. This is the correct/desired spelling.
  2. 3 occurrences of "agregator", all of which are in documentation. This is an incorrect spelling, but also happens in a more lose/descriptive context (e.g. "Embedly.com, which is a provider agregator.").

All that to say, I've fix the typos in documentation, but unless I've missed a typo that would more dicrely cause a problem, don't think I'll release a new version of the gem just for this.

Also, if anybody has a suggestion for a descriptor that's easier for everyone to spell than "aggregator" please let me know!

commented

@metavida no worries ;) Thanks for fixing. What about this and this? They are not in documentation, but rather in the API part, no? I agree that doc typos do not justify a new release, but perhaps these guys do.

commented

Ah yes, I see the source of confusion! There was a misspelling in the commit you're referencing, however in a subsequent commit I changed the behavior of the register_all method, removing the typo as a consequence. Sadly, I forgot to reference this ticket number in my commit message, which is why this ticket didn't have a direct link to the commit where I removed the typo. You can also check the "final" 0.8.7 implementation of register_all to confirm the typo is no longer there.

commented

Oh, okay. Sorry for the noise then.

commented

@vanto absolutely no problem. I'm very grateful for extra pairs of eyes to keep me honest! Hope to see you around the project in the future :-)